[sailfish-browser] Add unit test cases for suffling tabs #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usbnet connectivity script posted by @rainisto can be used to replace device's WLAN/3G/4G usage: See also other comments. |
rainemak
force-pushed
the
loadingUnitTest
branch
from
e952248 to
f48f02c
Compare
Aim is to automate a test where a WebPage stops responding. Added cases do not reproduce that error yet.
| } | ||
| } | ||
| return tabIds; | ||
| } |
There was a problem hiding this comment.
These two methods seem to do exactly the same work, but implemented with two different approaches.
I'd probably simplify it a bit: turn it into a list comprehension with a filter. And the list comprehension part could be shared between the methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim is to automate a test where a WebPage stops responding. Added
cases do not reproduce that error yet.
Requires: #208